Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player: don't load encoding mode profile twice #15227

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

llyyr
Copy link
Contributor

@llyyr llyyr commented Oct 30, 2024

Fixes #15224

Encoding mode used to be a compile time option, but now it's always
compiled in.
Also move the loading of profiles and input section activation in one
place. Leaving this in mp_initialize has the drawback that encoding
section profile will overwrite options set by the user in the command
line, since it's set after the CLI options are parsed and processed.
mp_parse_cfgfiles happens before parsing the CLI, so loading the profile
there is better.
@Arcitec
Copy link

Arcitec commented Oct 30, 2024

This looks fantastic. I also really appreciate that you discovered and moved the load-order so that CLI arguments take precedence over the [encoding] profile. That was a subtle bug that I hadn't even discovered yet and would really have hurt!

Copy link

Download the artifacts for this pull request:

Windows
macOS

@kasper93 kasper93 merged commit 5b946ac into mpv-player:master Oct 31, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[encoding] section executes twice on startup
4 participants